Fixed race condition in OnEnd and added a unit test #3951
Merged
+33
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaushal28
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Kaushal28
commented
Mar 30, 2023
pellared
previously requested changes
Mar 30, 2023
pellared
reviewed
Mar 30, 2023
dmathieu
reviewed
Mar 30, 2023
pellared
reviewed
Mar 30, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3951 +/- ##
=====================================
Coverage 82.1% 82.1%
=====================================
Files 175 175
Lines 12977 12977
=====================================
Hits 10655 10655
Misses 2102 2102
Partials 220 220
|
|
Hey @pellared , I have made all the changes as per your comments and also updated |
pellared
approved these changes
Mar 31, 2023
Co-authored-by: Robert Pająk <pellared@hotmail.com>
MrAlias
reviewed
Mar 31, 2023
hanyuancheung
approved these changes
Apr 3, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
|
Hey @MrAlias, incorporated your suggestions. Could you please have a look? |
pellared
approved these changes
Apr 14, 2023
dmathieu
approved these changes
Apr 14, 2023
Kaushal28
added a commit
to infracloudio/opentelemetry-go
that referenced
this pull request
Apr 21, 2023
) * Fixed race condition in OnEnd and added a test * fixed code review comments * fixed lint * Update CHANGELOG.md Co-authored-by: Robert Pająk <pellared@hotmail.com> * Update sdk/trace/simple_span_processor_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update sdk/trace/simple_span_processor_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update sdk/trace/simple_span_processor_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * fixed panic check --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3948
Fixed race condition in
OnEndand added a unit test.