-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document public metric SDK interfaces to remain stable #4396
Document public metric SDK interfaces to remain stable #4396
Conversation
Would it make sense to have tests that will fail if there are any new, modified, or removed exported methods? |
Adding test will only add a second place (the interface definitions in the test) where we are not allowed to change anything. I don't see that as very useful. We could potentially look into using https://pkg.go.dev/golang.org/x/exp/cmd/gorelease to automate all release with a versioning test. It would need more evaluation though. |
From IRL conversation with @pellared :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment.
Codecov Report
@@ Coverage Diff @@
## main #4396 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 220 220
Lines 17670 17670
=====================================
+ Hits 14378 14380 +2
+ Misses 2992 2990 -2
Partials 300 300
|
Resolve #3673
Similar to #2012, document for developers so they are aware things should not change in the SDK.