Deprecate Sortable #4734
Merged
Deprecate Sortable #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash2k
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4734 +/- ##
=======================================
- Coverage 83.5% 83.4% -0.1%
=======================================
Files 238 238
Lines 15757 15745 -12
=======================================
- Hits 13159 13143 -16
- Misses 2309 2314 +5
+ Partials 289 288 -1
|
|
CC @MrAlias |
MrAlias
previously requested changes
Dec 6, 2023
|
I've added a new benchmark that exercises the Because we are testing sorting, actual performance depends on the data being sorted. But this branch performs 1 allocation too. |
ash2k
force-pushed
the
remove-sortable
branch
2 times, most recently
from
7b76af7
to
c52d3d0
Compare
$ go1.20 version
go version go1.20 linux/amd64
$ go1.20 test -run='^$' -bench=NewSetWithSortableFiltered
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/attribute
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
BenchmarkNewSetWithSortableFiltered-8 2496835 480.1 ns/op 584 B/op 4 allocs/op
PASSOn main: $ go1.20 test -run='^$' -bench=NewSetWithSortableFiltered
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/attribute
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
BenchmarkNewSetWithSortableFiltered-8 4108585 283.9 ns/op 448 B/op 1 allocs/op
PASS |
|
On branch: I think we can consider this PR when we drop support for Go 1.20. |
|
This should be ready to merge now that #4967 is merged. Please update to remove the separate code paths for versions of Go less than 1.21 as they are no longer supported. |
New code: Old code: |
pellared
reviewed
Mar 6, 2024
MrAlias
reviewed
Mar 6, 2024
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
approved these changes
Mar 7, 2024
Co-authored-by: Robert Pająk <pellared@hotmail.com>
MrAlias
reviewed
Mar 7, 2024
|
@MrAlias Added back the benchmark. |
MrAlias
approved these changes
Mar 7, 2024
dmathieu
approved these changes
Mar 11, 2024
q-cheng
pushed a commit
to q-cheng/opentelemetry-go
that referenced
this pull request
Mar 12, 2024
* Deprecate Sortable * Remove redundant checks * Move code to a non-deprecated func * Apply suggestions from code review Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Mention individual deprecated function * Update attribute/set.go Co-authored-by: Robert Pająk <pellared@hotmail.com> * Add BenchmarkNewSet --------- Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Robert Pająk <pellared@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder what was the reason for introducing the methods with
*Sortablein the first place? Code in this PR works fine, but I couldn't find the benchmarks from #3832 to see if it allocates more or is slower. Any pointers?I ran the existing benchmarks and the results are identical old vs new on both Go 1.20.10 and 1.21.4.
1.20.10, old vs new:
1.21.4, old vs new:
New code, 1.20.10 vs 1.21.4:
There are some performance differences (not allocations though), but I only ran count=3 for the 1.21 version as I'm short on time today. I'll re-run that tomorrow with count=10 to improve accuracy.