Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the LoggerConfig and add the LoggerOptions #4937

Merged
merged 7 commits into from
Feb 18, 2024
Merged

Implement the LoggerConfig and add the LoggerOptions #4937

merged 7 commits into from
Feb 18, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 16, 2024

Resolve #4911

@MrAlias MrAlias added area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry labels Feb 16, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e2bfb6) 82.4% compared to head (31c0c6b) 82.5%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4937   +/-   ##
=====================================
  Coverage   82.4%   82.5%           
=====================================
  Files        237     237           
  Lines      18974   18999   +25     
=====================================
+ Hits       15649   15678   +29     
+ Misses      3035    3031    -4     
  Partials     290     290
Files Coverage Δ
log/logger.go 100.0% <100.0%> (+100.0%) ⬆️

@MrAlias MrAlias marked this pull request as ready for review February 16, 2024 16:40
XSAM
XSAM approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrAlias MrAlias merged commit e3e8879 into open-telemetry:main Feb 18, 2024
30 checks passed
@MrAlias MrAlias deleted the logger-conf branch February 18, 2024 16:13
@MrAlias MrAlias added this to the v1.24.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XSAM XSAM XSAM approved these changes

@dashpole dashpole dashpole approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.24.0/v0.46.0
Development

Successfully merging this pull request may close these issues.

Implement the Logger configuration
3 participants
@MrAlias @dashpole @XSAM