Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent default ErrorHandler self-delegation #5137

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 3, 2024

Fix #5135

  • Follow the pattern used for all other global state.
  • Self contain delegation to the ErrDelegator type and therefore remove the unneeded ErrLogger type.

@MrAlias MrAlias added this to the v1.25.0 milestone Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.7%. Comparing base (98fd439) to head (57bd075).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5137     +/-   ##
=======================================
- Coverage   83.7%   83.7%   -0.1%     
=======================================
  Files        252     252             
  Lines      16450   16458      +8     
=======================================
+ Hits       13772   13778      +6     
- Misses      2387    2389      +2     
  Partials     291     291             
Files Coverage Δ
handler.go 100.0% <100.0%> (ø)
internal/global/handler.go 100.0% <100.0%> (ø)
internal/global/state.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@pellared pellared merged commit 35c9570 into open-telemetry:main Apr 4, 2024
26 of 27 checks passed
@MrAlias MrAlias deleted the fix-5135 branch April 4, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow default ErrorHandler to be set as the ErrorHandler
5 participants