Address GO-2024-2687 #5139
Merged
Address GO-2024-2687 #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest releases of Go 1.22 and 1.21 contain security fixes for `net/http`. Explicitly set the CI system to not use vulnerable versions when testing so our vulnerable checker does not fail (and we aren't vulnerable).
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5139 +/- ##
=====================================
Coverage 83.9% 83.9%
=====================================
Files 248 248
Lines 16383 16383
=====================================
+ Hits 13747 13749 +2
+ Misses 2347 2345 -2
Partials 289 289 |
weslenteche
approved these changes
Apr 3, 2024
MrAlias
added
dependencies
dashpole
approved these changes
Apr 4, 2024
XSAM
approved these changes
Apr 4, 2024
hanyuancheung
approved these changes
Apr 4, 2024
MadVikingGod
approved these changes
Apr 4, 2024
pellared
approved these changes
Apr 4, 2024
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net/http. Explicitly set the CI system to not use vulnerable versions when testing so our vulnerable checker does not fail (and we aren't vulnerable).golang.org/x/nettov0.23.0