Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bump google.golang.org/grpc from 1.62.1 to 1.63.0 and use grpc.NewClient instead of grpc.DialContext #5151

Merged
merged 11 commits into from
Apr 4, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Apr 4, 2024

Bumps google.golang.org/grpc from 1.62.1 to 1.63.0.

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.63.0

Behavior Changes

  • grpc: Return canonical target string from resolver.Address.String() (experimental) (#6923)
  • client & server: when using write buffer pooling, use input value for buffer size instead of size*2 (#6983)

New Features

  • grpc: add ClientConn.CanonicalTarget() to return the canonical target string. (#7006)
  • xds: implement LRS named metrics support (gRFC A64) (#7027)
  • grpc: introduce grpc.NewClient to allow users to create new clients in idle mode and with "dns" as the default resolver (#7010)

API Changes

  • grpc: stabilize experimental method ClientConn.Target() (#7006)

Bug Fixes

  • xds: fix an issue that would cause the client to send an empty list of resources for LDS/CDS upon reconnecting with the management server (#7026)
  • server: Fix some errors returned by a server when using a grpc.Server as an http.Handler with the Go stdlib HTTP server (#6989)
  • resolver/dns: add SetResolvingTimeout to allow configuring the DNS resolver's global timeout (#6917)
  • Set the security level of Windows named pipes to NoSecurity (#6956)

Release 1.62.2

Dependencies

Commits
  • c68f456 Change version to 1.63.0 (#7050)
  • 6369167 *: update http2 dependency (#7082)
  • 8854761 cherry-pick: channelz: fix race accessing channelMap without lock (#7079) (#7...
  • e62770d channelz: add LocalAddr to listen sockets and test (#7062) (#7063)
  • 4ffccf1 googlec2p: use xdstp style template for client LDS resource name (#7048)
  • faf9964 gracefulswitch: add ParseConfig and make UpdateClientConnState call SwitchTo ...
  • 800a8e0 channelz: re-add state for subchannels (#7046)
  • dadbbfa channelz: re-add target and state (#7042)
  • 55cd7a6 channelz: major cleanup / reorganization (#6969)
  • a1033b1 xds: add LRS named metrics support (#7027)
  • Additional commits viewable in compare view

grpc.DialContext is deprecated. otlptracegrpc and otlpmetricgrpc create a gRPC client in idle mode and with "dns" as the default resolver using grpc.NewClient. Because of that WithDialOption ignores grpc.WithBlock, grpc.WithTimeout, and grpc.WithReturnConnectionError.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.7%. Comparing base (0168437) to head (9346617).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5151     +/-   ##
=======================================
- Coverage   83.7%   83.7%   -0.1%     
=======================================
  Files        252     252             
  Lines      16450   16450             
=======================================
- Hits       13772   13770      -2     
- Misses      2388    2389      +1     
- Partials     290     291      +1     
Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 92.2% <100.0%> (ø)
exporters/otlp/otlpmetric/otlpmetricgrpc/config.go 43.6% <ø> (ø)
exporters/otlp/otlptrace/otlptracegrpc/client.go 89.9% <100.0%> (-1.9%) ⬇️
exporters/otlp/otlptrace/otlptracegrpc/options.go 76.4% <ø> (ø)

@pellared pellared changed the title Bump grpc and use grpc.NewClient instead of grpc.DialContext Bump bump google.golang.org/grpc from 1.62.1 to 1.63.0 and use grpc.NewClient instead of grpc.DialContext Apr 4, 2024
example/otel-collector/main.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pellared and others added 2 commits April 4, 2024 18:27
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@pellared pellared requested a review from dashpole April 4, 2024 17:44
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pellared
Copy link
Member Author

pellared commented Apr 4, 2024

Merging per discussion during SIG.

@pellared pellared merged commit 98fd439 into open-telemetry:main Apr 4, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants