-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bump google.golang.org/grpc from 1.62.1 to 1.63.0 and use grpc.NewClient instead of grpc.DialContext #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5151 +/- ##
=======================================
- Coverage 83.7% 83.7% -0.1%
=======================================
Files 252 252
Lines 16450 16450
=======================================
- Hits 13772 13770 -2
- Misses 2388 2389 +1
- Partials 290 291 +1
|
pellared
changed the title
Bump grpc and use grpc.NewClient instead of grpc.DialContext
Bump bump google.golang.org/grpc from 1.62.1 to 1.63.0 and use grpc.NewClient instead of grpc.DialContext
Apr 4, 2024
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
April 4, 2024 08:39
dashpole
reviewed
Apr 4, 2024
MrAlias
approved these changes
Apr 4, 2024
dmathieu
reviewed
Apr 4, 2024
Co-authored-by: Damien Mathieu <42@dmathieu.com>
dashpole
approved these changes
Apr 4, 2024
XSAM
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merging per discussion during SIG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps google.golang.org/grpc from 1.62.1 to 1.63.0.
Release notes
Sourced from google.golang.org/grpc's releases.
Commits
c68f456
Change version to 1.63.0 (#7050)6369167
*: update http2 dependency (#7082)8854761
cherry-pick: channelz: fix race accessing channelMap without lock (#7079) (#7...e62770d
channelz: add LocalAddr to listen sockets and test (#7062) (#7063)4ffccf1
googlec2p: use xdstp style template for client LDS resource name (#7048)faf9964
gracefulswitch: add ParseConfig and make UpdateClientConnState call SwitchTo ...800a8e0
channelz: re-add state for subchannels (#7046)dadbbfa
channelz: re-add target and state (#7042)55cd7a6
channelz: major cleanup / reorganization (#6969)a1033b1
xds: add LRS named metrics support (#7027)grpc.DialContext
is deprecated.otlptracegrpc
andotlpmetricgrpc
create a gRPC client in idle mode and with "dns" as the default resolver usinggrpc.NewClient
. Because of thatWithDialOption
ignoresgrpc.WithBlock
,grpc.WithTimeout
, andgrpc.WithReturnConnectionError
.