-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Record
limit methods with DroppedAttributes
#5190
Conversation
076a3af
to
30c5958
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5190 +/- ##
=====================================
Coverage 84.3% 84.3%
=====================================
Files 258 258
Lines 16974 17042 +68
=====================================
+ Hits 14313 14383 +70
+ Misses 2362 2360 -2
Partials 299 299
|
Reduce indentation level.
Comment compactAttr and deduplicate.
I just want to say that I support the API changes (addition of I had no time to review this PR yet. |
Do not run this test when the race detector is on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need benchmarks for AddAttributes
and SetAttributes
in the following tasks?
We do. That is left to #5054 |
Resolve #5186
Similar to the trace SDK, de-duplicate the attributes before dropping.
Note, this does not include any truncation of string and string slice attributes. That is left for a follow-up PR.
Follow-up Tasks
string
and[]string
value types to configured limit #5217