-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add span flags to OTLP exported data #5194
Conversation
7d23ef4
to
ae48e39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5194 +/- ##
=====================================
Coverage 84.3% 84.3%
=====================================
Files 258 258
Lines 16966 16974 +8
=====================================
+ Hits 14305 14313 +8
Misses 2362 2362
Partials 299 299
|
ae48e39
to
b13675c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- The
is remote parent
falgs need also to be set for the SpanLinks flags. - We need to retrieve the information about
isRemote
from the parent's SpanContext (see comment below)
071eb16
to
0961831
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after Alex's comments are addressed, LGTM
0961831
to
0d9b925
Compare
55bc772
to
c65f533
Compare
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This adds the new span flags into the OTLP exported data.
See open-telemetry/opentelemetry-proto#503