Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span flags to OTLP exported data #5194

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

dmathieu
Copy link
Member

This adds the new span flags into the OTLP exported data.
See open-telemetry/opentelemetry-proto#503

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.3%. Comparing base (e518c7e) to head (25e9c88).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5194   +/-   ##
=====================================
  Coverage   84.3%   84.3%           
=====================================
  Files        258     258           
  Lines      16966   16974    +8     
=====================================
+ Hits       14305   14313    +8     
  Misses      2362    2362           
  Partials     299     299           
Files Coverage Δ
...ers/otlp/otlptrace/internal/tracetransform/span.go 96.7% <100.0%> (+0.2%) ⬆️

@dmathieu dmathieu marked this pull request as ready for review April 11, 2024 08:35
@dmathieu dmathieu changed the title Add W3C-specified span flags to OTLP exported data Add span flags to OTLP exported data Apr 11, 2024
Copy link
Member

@AlexanderWert AlexanderWert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. The is remote parent falgs need also to be set for the SpanLinks flags.
  2. We need to retrieve the information about isRemote from the parent's SpanContext (see comment below)

exporters/otlp/otlptrace/internal/tracetransform/span.go Outdated Show resolved Hide resolved
@dmathieu dmathieu force-pushed the otlp-trace-flags branch 2 times, most recently from 071eb16 to 0961831 Compare April 11, 2024 08:59
Copy link

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after Alex's comments are addressed, LGTM

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit 1ff2e71 into open-telemetry:main Apr 15, 2024
27 checks passed
@MrAlias MrAlias added this to the v1.26.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants