Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otlploggrpc exporter prototype #5522

Closed
wants to merge 15 commits into from
Closed

otlploggrpc exporter prototype #5522

wants to merge 15 commits into from

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Jun 19, 2024

Towards #5056

The PR contains a prototype implementation. To improve the review experience, I will create smaller PRs from this one.

@XSAM XSAM mentioned this pull request Jun 19, 2024
Closed
18 tasks
@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (b761af7) to head (b69ae60).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5522   +/-   ##
=====================================
  Coverage   84.4%   84.5%           
=====================================
  Files        271     271           
  Lines      22388   22407   +19     
=====================================
+ Hits       18913   18950   +37     
+ Misses      3143    3124   -19     
- Partials     332     333    +1

see 5 files with indirect coverage changes

@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 19, 2024
@XSAM XSAM mentioned this pull request Jun 19, 2024
Merged
MrAlias added a commit that referenced this pull request Jun 24, 2024
@XSAM @dmathieu @MrAlias
Add newClient method for otlploggrpc gRPC client (#5523)
d99c76f 
part of #5056

For full usage of this client, check #5522

---------

Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@XSAM XSAM mentioned this pull request Jun 27, 2024
Merged
pellared pushed a commit that referenced this pull request Jun 28, 2024
@XSAM
Generate internal/transform in otlploggrpc (#5553)
82fe9aa 
Part of #5056

It abstracts the `transform` package from `otlploghttp` and makes it a
shared template. Then, it generates the abstracted `transform` package
into `otlploggrpc`.

For full usage of this transform package, check
#5522
@XSAM XSAM mentioned this pull request Jul 3, 2024
Merged
XSAM added a commit that referenced this pull request Jul 4, 2024
@XSAM @dmathieu
Implement otlploggrpc gRPC client (#5572)
5cd7807 
part of #5056

For full usage of this client, check
#5522

---------

Co-authored-by: Damien Mathieu <42@dmathieu.com>
@XSAM XSAM mentioned this pull request Jul 6, 2024
Merged
pellared pushed a commit that referenced this pull request Jul 9, 2024
@XSAM @MrAlias
Implement otlploggrpc exporter (#5582)
4816927 
Part of #5056

It also abstracts some test help functions from the client and adjusts
the indent of `UploadLogs` and `PartialSuccess` in client tests.

For full usage of this exporter, check
#5522

---------

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@XSAM
Copy link
Member Author

XSAM commented Jul 17, 2024

Close as the changes have been merged into the main branch.

@XSAM XSAM closed this Jul 17, 2024
@XSAM XSAM deleted the otlploggrpc-draft branch July 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias will be requested when the pull request is marked ready for review MrAlias is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole will be requested when the pull request is marked ready for review dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared will be requested when the pull request is marked ready for review pellared is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu will be requested when the pull request is marked ready for review dmathieu is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XSAM