Ensure codespell failures fail CI #5761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
added
Skip Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5761 +/- ##
=====================================
Coverage 84.5% 84.6%
=====================================
Files 272 272
Lines 22759 22759
=====================================
+ Hits 19252 19255 +3
+ Misses 3167 3164 -3
Partials 340 340 |
dmathieu
requested review from
MrAlias,
XSAM,
dashpole,
MadVikingGod,
pellared and
hanyuancheung
as code owners
pellared
approved these changes
Sep 2, 2024
XSAM
approved these changes
Sep 2, 2024
dmathieu
added a commit
to open-telemetry/opentelemetry-go-contrib
that referenced
this pull request
Sep 3, 2024
With the `write` option, codespell fixes issues (which is a nice behavior when we run it locally), but it also returns a 0 status code (except if some failures couldn't be fixed). So in order to actually fix the CI on a failing codespell, we need to ensure the working directory is clean. SDK counterpart: open-telemetry/opentelemetry-go#5761
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
writeoption, codespell fixes issues (which is a nice behavior when we run it locally), but it also returns a 0 status code (except if some failures couldn't be fixed).So in order to actually fix the CI on a failing codespell, we need to ensure the working directory is clean.