-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #5763
Fix typos #5763
Conversation
There's also over 40 instances of the phrase "...represents the sHOULD be a semantic identifier..." which looks pretty wrong, but I'm not sure what it's trying to say. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5763 +/- ##
=====================================
Coverage 84.5% 84.5%
=====================================
Files 272 272
Lines 22798 22798
=====================================
+ Hits 19282 19285 +3
+ Misses 3173 3170 -3
Partials 343 343 |
Thanks for fixing all these. For the most part, these look good. I would want to back out the |
I agree @MrAlias - the semconv tooling typos have been fixed upstream (open-telemetry/semantic-conventions#1060 open-telemetry/semantic-conventions#1379) so those should be fixed automatically once we upgrade to the upcoming |
The lint issue needs to be fixed (there's a generated file for which the template was not modified). |
Ah, I see it now @dmathieu, fixed. |
Just thought I'd contribute some typo fixes I stumbled upon. Nothing controversial (hopefully), just 122 simple fixes.
Use the following command to get a quick and dirty summary of the specific corrections made:
FWIW, the top typos are: