Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-kube-stack] Adding additional labels #1382

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/opentelemetry-kube-stack/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-kube-stack
version: 0.3.0
version: 0.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the linter is still failing because of some whitespacing issues? Did your linter/formatter automatically remove extra spacing potentially?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not, i can try running this locally and see what happens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaronoff97 I'm closing this PR and created another one #1388

description: |
OpenTelemetry Quickstart chart for Kubernetes.
Installs an operator and collector for an easy way to get started with Kubernetes observability.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ kind: OpAMPBridge
metadata:
name: example
labels:
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
release: "example"
spec:
endpoint: http://opamp-server:8080
capabilities:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ metadata:
name: example-cluster-stats
namespace: default
labels:
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
release: "example"
opentelemetry.io/opamp-reporting: "true"
spec:
managementState: managed
Expand Down Expand Up @@ -174,7 +174,7 @@ spec:
fieldPath: status.podIP
- name: OTEL_RESOURCE_ATTRIBUTES
value: "k8s.cluster.name=demo"

- name: ACCESS_TOKEN
valueFrom:
secretKeyRef:
Expand All @@ -189,10 +189,10 @@ metadata:
name: example-daemon
namespace: default
labels:
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
release: "example"
opentelemetry.io/opamp-reporting: "true"
spec:
managementState: managed
Expand Down Expand Up @@ -644,7 +644,7 @@ spec:
fieldPath: status.podIP
- name: OTEL_RESOURCE_ATTRIBUTES
value: "k8s.cluster.name=demo"

- name: ACCESS_TOKEN
valueFrom:
secretKeyRef:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ spec:
- -c
- |
kubectl delete instrumentations,opampbridges,opentelemetrycollectors \
-l helm.sh/chart=opentelemetry-kube-stack-0.3.0
-l helm.sh/chart=opentelemetry-kube-stack-0.3.1
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ kind: Instrumentation
metadata:
name: example
labels:
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
release: "example"
spec:
exporter:
endpoint: http://${OTEL_K8S_NODE_NAME}:4317
Expand All @@ -20,7 +20,7 @@ spec:
- jaeger
- xray
- ottrace
env:
env:
- name: OTEL_K8S_NODE_NAME
valueFrom:
fieldRef:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ metadata:
name: example-daemon
namespace: default
labels:
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
release: "example"
spec:
managementState: managed
mode: daemonset
Expand Down Expand Up @@ -341,7 +341,7 @@ spec:
fieldPath: status.podIP
- name: OTEL_RESOURCE_ATTRIBUTES
value: "k8s.cluster.name=demo"

- name: ACCESS_TOKEN
valueFrom:
secretKeyRef:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ metadata:
namespace: default
labels:
app: opentelemetry-kube-stack-apiserver
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
spec:

endpoints:
- bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
port: https
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ metadata:
labels:
app: opentelemetry-kube-stack-kube-controller-manager
jobLabel: kube-controller-manager
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ metadata:
namespace: default
labels:
app: opentelemetry-kube-stack-kube-controller-manager
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
spec:
jobLabel: jobLabel

selector:
matchLabels:
app: opentelemetry-kube-stack-kube-controller-manager
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ metadata:
labels:
app: opentelemetry-kube-stack-kube-dns
jobLabel: kube-dns
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ metadata:
namespace: default
labels:
app: opentelemetry-kube-stack-kube-dns
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
spec:
jobLabel: jobLabel

selector:
matchLabels:
app: opentelemetry-kube-stack-kube-dns
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ metadata:
labels:
app: opentelemetry-kube-stack-kube-etcd
jobLabel: kube-etcd
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ metadata:
namespace: default
labels:
app: opentelemetry-kube-stack-kube-etcd
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
spec:
jobLabel: jobLabel

selector:
matchLabels:
app: opentelemetry-kube-stack-kube-etcd
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ metadata:
labels:
app: opentelemetry-kube-stack-kube-proxy
jobLabel: kube-proxy
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ metadata:
namespace: default
labels:
app: opentelemetry-kube-stack-kube-proxy
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
spec:
jobLabel: jobLabel

selector:
matchLabels:
app: opentelemetry-kube-stack-kube-proxy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ metadata:
labels:
app: opentelemetry-kube-stack-kube-scheduler
jobLabel: kube-scheduler
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ metadata:
namespace: default
labels:
app: opentelemetry-kube-stack-kube-scheduler
helm.sh/chart: opentelemetry-kube-stack-0.3.0
helm.sh/chart: opentelemetry-kube-stack-0.3.1
app.kubernetes.io/version: "0.107.0"
app.kubernetes.io/managed-by: Helm
release: "example"
spec:
jobLabel: jobLabel

selector:
matchLabels:
app: opentelemetry-kube-stack-kube-scheduler
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,4 @@ spec:
- -c
- |
kubectl delete instrumentations,opampbridges,opentelemetrycollectors \
-l helm.sh/chart=opentelemetry-kube-stack-0.3.0
-l helm.sh/chart=opentelemetry-kube-stack-0.3.1
2 changes: 1 addition & 1 deletion charts/opentelemetry-kube-stack/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -3262,7 +3262,7 @@
},
"AdditionalLabels": {
"type": "object",
"additionalProperties": false,
"additionalProperties": true,
"title": "AdditionalLabels"
},
"EnableConfigBlock": {
Expand Down
Loading