-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helm chart to account for changes to loadgenerator #330
Update helm chart to account for changes to loadgenerator #330
Conversation
@Mwad22 please sign the CLA |
Just signed! |
@Mwad22 do you know how long it'll be till the new images our available? |
I believe once this PR lands. @austinlparker @puckpuck I believe this was mentioned in the otel-demo slack, but can one of you confirm? thanks! |
@Mwad22 still interested in this PR? |
Yes, will update it tomorrow! |
@Mwad22 please bump the chart version |
Just bumped it! |
@Mwad22 have you tested this branch with the new official demo images (0.3.4)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@TylerHelmuth I just tested it again, everything seems to work as expected- with the new Locust UI and everything else! |
Now that this issue in opentelemetry-demo repo has been resolved, the helm chart needs to be changed. Specifically, my PR maps the changes in this merged PR to do the following:
servicePort
field) so users can usekubectl port-forward [service] [port]
and interact with the locust UINOTE: this can only be merged after new images are built/deployed as current images built the loadgenerator with different environment variables and a
--headless
tag that disables the locust UIRe: Testing
I have tested the full functionality following helm chart changes on k8s by generating the template (using
helm template
) and replacing the image with my own docker image of locust.