AWS X-Ray remote sampler does not poll for new rules

[felixscheinost]

Description

AWS X-Ray remote sampler does not poll for updated sampling configuration in the default configuration.

Any configuration which has a polling interval smaller than roughly 3.3 minutes is expected to work currently.

I already addeed a comment in #133 but decided to open a separate issue instead.

Steps to reproduce

Run in default configuration.

Expectation

I expect the sampling configuration to be fetched every 5 minutes.

What applicable config did you use?

AWS X-Ray OpenTelemetry distro Java agent with java option -Dotel.traces.sampler=xray

Relevant Environment Information

Version: 1.14.0 but main should be affecteed as well.
OS: macOS and AWS Fargate

Additional context

I configured the -Dotel.traces.sampler=xray on my development machine where it is expected to fail as I don't have any AWS proxy running locally but should still at least try every 5 minutes.

I set a breakpoint here

opentelemetry-java-contrib/aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/AwsXrayRemoteSampler.java

Line 151 in 7c23e02

long delay = pollingIntervalNanos + RANDOM.nextInt(jitterNanos);

and noticed that in my case jitterNanos = -1294967296. This screams truncation error so I checked where jitterNanos is set. It is set here

opentelemetry-java-contrib/aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/AwsXrayRemoteSampler.java

Line 98 in 7c23e02

jitterNanos = (int) (pollingIntervalNanos / 100);

so 1% of the pollingIntervalNanos but cast to int.

Default is pollingIntervalNanos = 300000000000 = 3 * 10^11, so pollingIntervalNanos / 100 = 3 * 10^9 which is bigger than Integer.MAX_VALUE = 2147483647 ~= 2.1 * 10^9

I see the reason why it is cast to int is because there is a method Random.nextInt(Int) but no method Random.nextLong(Long).

I think the easiest fix would be to store the polling interval in milliseconds instead. I don't think nanoseconds makes sense here.