Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved java doc, explicit passing of invalid p-value to root sampler #1053

Merged
merged 1 commit into from
Sep 25, 2023
Merged

improved java doc, explicit passing of invalid p-value to root sampler #1053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...c/main/java/io/opentelemetry/contrib/sampler/consistent/ConsistentParentBasedSampler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@
import javax.annotation.concurrent.Immutable;

/**
* A consistent sampler that makes the same sampling decision as the parent and optionally falls
* back to an alternative consistent sampler, if the parent p-value is invalid (like for root
* spans).
* A consistent sampler that makes the same sampling decision as the parent. For root spans, the
* sampling decision is delegated to the root sampler.
*/
@Immutable
final class ConsistentParentBasedSampler extends ConsistentSampler {
Expand All @@ -38,7 +37,7 @@ final class ConsistentParentBasedSampler extends ConsistentSampler {
@Override
protected int getP(int parentP, boolean isRoot) {
if (isRoot) {
return rootSampler.getP(parentP, isRoot);
return rootSampler.getP(OtelTraceState.getInvalidP(), isRoot);
} else {
return parentP;
}
Expand Down
Loading