Add Error handling for closure parameters #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
breedx-splk
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Looks good to me. @akats7 it looks like you need to sign the CLA, also please format using ./gradlew spotlessApply. Thanks!
| @@ -123,7 +123,16 @@ class MBeanHelper { | |||
|
|
|||
| Object getBeanAttributeWithTransform(GroovyMBean bean, String attribute){ | |||
| def transformationClosure = attributeTransformation.get(attribute); | |||
| return transformationClosure != null ? transformationClosure(bean) : getBeanAttribute(bean, attribute) | |||
| if (transformationClosure != null){ | |||
There was a problem hiding this comment.
nit: I like inverting this and returning null early because it helps to reduce the indent levels (reader burden).
Hey @breedx-splk, thanks will do, I must be missing some metadata on a commit, I’ll rebase. |
akats7
force-pushed
the
gatherer-errors
branch
from
cdc8aa8
to
9d47952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #960 we discussed the way we handle attributes that do not exist when extracted from user defined closures, currently this will throw an AttributeNotFoundException, which does not seem like the correct pattern. This should should just be handled gracefully and in the case if the transformation just avoid creating the metric and in the case of the labels, omit that label.
Existing Issue(s):
N/A
Testing: