Add AWS ECS cluster detection #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzlei
approved these changes
Jun 28, 2024
srprash
approved these changes
Jul 2, 2024
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/EcsResource.java
Show resolved
Hide resolved
aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/IncubatingAttributes.java
Show resolved
Hide resolved
|
@open-telemetry/java-contrib-approvers Please help review, thanks! |
But I'm not a maintainer over here, so someone who is will need to approve before we can merge. |
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
< Describe what is being changed or added.
Ex. Bug fix - Describe the bug and how this fixes it.
Ex. Feature addition - Describe what this provides and why. >
aws.ecs.cluster.arn is not populated in the ecs resource attributes.
This PR reads
Clusterfrom ECS task metadata API, and setsaws.ecs.cluster.arninto resource attributes.Testing:
UT passed.