Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change link checking from markdown-link-check to lychee #1570

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

trask
Copy link
Member

@trask trask commented Nov 25, 2024

No description provided.

@trask trask force-pushed the lychee branch 4 times, most recently from a697196 to ebe5e04 Compare November 25, 2024 22:37
@trask trask marked this pull request as ready for review November 25, 2024 22:38
@trask trask requested a review from a team as a code owner November 25, 2024 22:38
@trask trask force-pushed the lychee branch 3 times, most recently from 29ec0f8 to 71ee302 Compare November 25, 2024 22:52
@trask trask marked this pull request as draft November 25, 2024 22:53
@trask trask force-pushed the lychee branch 14 times, most recently from 3206b5d to 80d444b Compare November 26, 2024 03:04
@trask trask changed the title Lychee Change link checking from markdown-link-check to lychee Nov 26, 2024
Copy link

@sfriberg sfriberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFR MD changes looks ok

@trask trask force-pushed the lychee branch 4 times, most recently from e4ac622 to 4fee4b5 Compare November 30, 2024 02:16
@trask trask force-pushed the lychee branch 4 times, most recently from 03ce3d5 to 1e2c3d7 Compare December 19, 2024 02:55
@trask trask marked this pull request as ready for review December 20, 2024 20:27
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we just not linking to the javadocs anymore? I'm fine with it, just wondering.

@trask
Copy link
Member Author

trask commented Dec 20, 2024

Are we just not linking to the javadocs anymore? I'm fine with it, just wondering.

only 2 out of 25 components had the links, so didn't seem worth adding a link checking exception for them

also see my thoughts here:

@trask trask merged commit 7febaa8 into open-telemetry:main Dec 20, 2024
14 checks passed
@trask trask deleted the lychee branch December 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants