-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update change log for upcoming release #1596
Conversation
### JMX metrics | ||
|
||
- Align HBase metric units to semconv | ||
([#1538](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1538)) | ||
- Align Cassandra metric units to semconv | ||
([#1591](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1591)) | ||
- Align Tomcat metric units to semconv | ||
([#1589](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1589)) | ||
- Align JVM units to semconv | ||
([#1593](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1593)) | ||
|
||
### JMX scraper - New 🌟 | ||
|
||
The future of the [JMX metrics](./jmx-metrics/README.md) component, | ||
built on top of the | ||
[JMX metrics](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/jmx-metrics/javaagent#jmx-metric-insight) | ||
component from the opentelemetry-java-instrumentation repository. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
grep -Po "val stableVersion = \"\K[0-9]+.[0-9]+.[0-9]+" version.gradle.kts | ||
grep "val stableVersion = " version.gradle.kts | grep -Eo "[0-9]+.[0-9]+.[0-9]+" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested both on debian and macos...the grep -p
one fails on a mac, so that seems like a worthy improvement when developing locally....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason grep -P
used to work for me (windows / git bash) but no longer 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-P
is probably a GNU grep extension. Try running grep --version
. Mac uses grep (BSD grep, GNU compatible) 2.6.0-FreeBSD
brew install grep
installs gnu grep as ggrep
.
([#1589](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1589)) | ||
- Align JVM units to semconv | ||
([#1593](https://github.com/open-telemetry/opentelemetry-java-contrib/pull/1593)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, it looks like these were included in the last release, but I missed adding them to the change log / release notes
I'll send a separate PR to update the change log for 1.41.0 and I'll manually update the release notes
No description provided.