Improve exception handling and documentation of runtime attachment #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime-attach-core/src/main/java/io/opentelemetry/contrib/attach/AgentFileProvider.java
Outdated
Show resolved
Hide resolved
runtime-attach-core/src/main/java/io/opentelemetry/contrib/attach/CoreRuntimeAttach.java
Outdated
Show resolved
Hide resolved
|
Thank you for your suggestions @mateuszrzeszutek! |
mateuszrzeszutek
approved these changes
Jul 11, 2022
runtime-attach-core/src/main/java/io/opentelemetry/contrib/attach/CoreRuntimeAttach.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Jul 11, 2022
Comment on lines
+13
to
+14
| * The application is running on a JRE (a JDK is necessary) | ||
| * The application is running on a read-only file system |
runtime-attach-core/src/main/java/io/opentelemetry/contrib/attach/CoreRuntimeAttach.java
Outdated
Show resolved
Hide resolved
6 tasks
jeanbisutti
force-pushed
the
runtime-attach-jre-readonly
branch
from
f555128 to
e20839f
Compare
|
The runtime attach files were moved in #385. So resynched with main and added a new commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve exception handling and documentation of runtime attachment