Handle missing attributes without failing #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehaansa
requested review from
anuraaga,
pmcollins,
rmfitzpatrick and
trask
as code owners
rmfitzpatrick
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Enhance InstrumentHelper & MBeanHelper to handle AttributeNotFoundException cleanly. Prior to this PR, if a groovy script included an instrument where the MBean existed but the Attribute was missing, it would fail and the remainder of the metrics listed afterwards in the groovy script would not be collected. This PR makes the AttributeNotFoundException cause that metric to be missing, but the remainder of the script's requested metrics are still collected.
Existing Issue(s): #38
Testing: Enhanced groovy tests to capture this.