Demosntrate declarative config 0.3 with otel java agent #492
+354
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
approved these changes
Sep 23, 2024
jack-berg
commented
Sep 23, 2024
| @@ -24,7 +24,7 @@ dependencies { | |||
| //spring modules | |||
| implementation("org.springframework.boot:spring-boot-starter-web") | |||
|
|
|||
| agent("io.opentelemetry.javaagent:opentelemetry-javaagent:2.8.0") | |||
| agent("io.opentelemetry.javaagent:opentelemetry-javaagent:2.9.0-SNAPSHOT") | |||
There was a problem hiding this comment.
Don't merge until next release of opentelemetry-java-instrumentation and the -SNAPSHOT is reverted.
There was a problem hiding this comment.
Is it that important tho for examples? As long as renovate knows to bump it.....I dunno.
breedx-splk
reviewed
Sep 27, 2024
Comment on lines
+167
to
+168
| dropwizard-metrics: | ||
| enabled: true |
There was a problem hiding this comment.
This instrumentation is not enbabled by default....do we want it enabled here? This also applies to:
- jdbc-datasource
- micrometer
- mybatis
- spring-batch
There was a problem hiding this comment.
it should reflect the default values I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates how declarative config is integrated with the otel java agent and can be used to configure instrumentations.
Related to: open-telemetry/opentelemetry-java-instrumentation#12265