Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc.server.duration metric description is incorrect #9478

Open
puckpuck opened this issue Sep 15, 2023 · 3 comments
Open

rpc.server.duration metric description is incorrect #9478

puckpuck opened this issue Sep 15, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@puckpuck
Copy link

Describe the bug

The rpc.server.duration metric has a description that does not conform with the OpenTelemetry semantic convention. This creates an issue when used with OpenTelemetry instrumented services that emit the same metric from a different language SDK (ie: Go). The OpenTelemetry Collector's, Prometheus exporter will specifically drop a metric if received that has the same name but a different description from a metric previously received.

We have run into this issue on the OpenTelemetry Demo project, our workaround is to write a special transform rule to remove descriptions from offending metrics.

Steps to reproduce

Using the gRPC auto instrumentation library with metrics being exported.

Expected behavior

The description for the rpc.server.duration metric should be: Measures the duration of inbound RPC.

This is defined in the OpenTelemetry semantic convention for this metric.

Actual behavior

The description for the rpc.server.duration metric is: The duration of an inbound RPC invocation

Javaagent or library instrumentation version

1.30.0

Environment

No response

Additional context

https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation-api-semconv/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerMetrics.java#L42

@puckpuck puckpuck added bug Something isn't working needs triage New issue that requires triage labels Sep 15, 2023
@trask
Copy link
Member

trask commented Sep 15, 2023

hey @puckpuck! I think this will be resolved by #9264, we missed getting this into 1.30.0, I just tagged it for 1.31.0 so we will make sure to get it in before then

@puckpuck
Copy link
Author

Do you know how to tag this issue so it will close when #9264 is merged?

@laurit
Copy link
Contributor

laurit commented Sep 17, 2023

@puckpuck I have update the pr so that merging it will close this issue

@mateuszrzeszutek mateuszrzeszutek removed the needs triage New issue that requires triage label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants