[grpc] fix rpc.server.duration metric description
#9479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9478
This sets the description for the
rpc.server.durationmetric. This description is set as defined by the semantic convention for this metric.When used with other services written in other languages that emit the same metric, all services must emit the same metric metadata (name, description) when used in conjunction with a Prometheus backend. The OpenTelemetry Collector, Prometheus exporter, will drop metrics that match the name but not the description against already received metrics. We have faced this problem as part of the OpenTelemetry demo project.