Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transforming record types #10052

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix transforming record types #10052

merged 2 commits into from
Dec 13, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Dec 12, 2023

Resolves #10046

@laurit laurit requested a review from a team December 12, 2023 12:54
trask
trask approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any thoughts around managing these ASM updates? is there a downside to always using the latest "stable" asm version (if we could determine that or create a shared constant somewhere for it)?

@laurit
Copy link
Contributor Author

laurit commented Dec 13, 2023

create a shared constant somewhere for it

Did that, I used the same approach in a previous project and it worked well.
The reasoning behind the api version is described in https://asm.ow2.io/asm4-guide.pdf chapter 5. Using a shared constant kind of goes against the raise an error when in doubt philosophy presented there, but I think for our purposes it will be fine.

@trask trask merged commit 30ddf6a into open-telemetry:main Dec 13, 2023
47 checks passed
heyams pushed a commit to heyams/opentelemetry-java-instrumentation that referenced this pull request Dec 13, 2023
@laurit @heyams
Fix transforming record types (open-telemetry#10052)
29c1a3f
elbiocaetano pushed a commit to elbiocaetano/opentelemetry-java-instrumentation that referenced this pull request Dec 19, 2023
@laurit @elbiocaetano
Fix transforming record types (open-telemetry#10052)
c48b57c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spring boot 3.2/jetty: UnsupportedOperationException: Records requires ASM8
3 participants
@laurit @trask @mateuszrzeszutek