Add UserExcludedClassloadersConfigurer #10134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Jan 2, 2024
.../main/java/io/opentelemetry/javaagent/tooling/ignore/UserExcludedClassloadersConfigurer.java
Outdated
Show resolved
Hide resolved
|
Could you also document the new flag in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/advanced-configuration-options.md |
anhermon
force-pushed
the
patch-1
branch
8 times, most recently
from
9391bdc to
5e55412
Compare
laurit
reviewed
Jan 9, 2024
...c/main/java/io/opentelemetry/javaagent/tooling/ignore/UserExcludedClassLoaderConfigurer.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/javaagent/tooling/ignore/UserExcludedClassLoaderConfigurer.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/opentelemetry/javaagent/tooling/ignore/UserExcludedClassLoaderConfigurer.java
Outdated
Show resolved
Hide resolved
Create UserExcludedClassLoadersConfigurer Add documentation for otel.javaagent.exclude-classLoaders property Add UserExcludedClassLoadersConfigurerTest
laurit
approved these changes
Jan 9, 2024
|
hi @anhermon! can you mark this PR as "Ready for review" to move it out of draft status? thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add an option to add ignoreClassLoader via a property (otel.javaagent.exclude-classloaders)