Fix Calling shutdown() multiple times warning in spring starter #10222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
changed the title
laurit
force-pushed
the
sprin-starter-shutdown
branch
from
db9a9fa to
b383409
Compare
jeanbisutti
approved these changes
Jan 17, 2024
trask
approved these changes
Jan 17, 2024
...va/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running tests I noticed the following warnings
these happen because all these providers are closed when
OpenTelemetrySdkis close and as these providers implementAutoCloseablespring calls close for each of them once more. This pr prevents spring'sAutoCloseablehandling on the beans that are shut down along with theOpenTelemetrySdk.