Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LoggingMetricExporterAutoConfiguration to spring factories #10282

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

zeitlinger
Copy link
Member

it was forgotten before

@zeitlinger zeitlinger requested a review from a team January 18, 2024 17:17
@zeitlinger zeitlinger self-assigned this Jan 18, 2024
Copy link
Member

@jeanbisutti jeanbisutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be useful to add automatic tests as it's done for LoggingSpanExporter

@zeitlinger
Copy link
Member Author

It may be useful to add automatic tests as it's done for LoggingSpanExporter

adding external tests is quite an effort: I've done that for various spring configurations and versions in a distro - and I'm happy to contribute that - but it's quite big.

@jeanbisutti
Copy link
Member

It may be useful to add automatic tests as it's done for LoggingSpanExporter

adding external tests is quite an effort: I've done that for various spring configurations and versions in a distro - and I'm happy to contribute that - but it's quite big.

There are several tests verifying the presence or absence of the LoggingSpanExporter bean, for different configurations. See this test for example. You could do the same thing for the LoggingMetricExporter bean.

@jeanbisutti
Copy link
Member

It would be great to document this feature on https://opentelemetry.io/ after the next release

@zeitlinger
Copy link
Member Author

It may be useful to add automatic tests as it's done for LoggingSpanExporter

adding external tests is quite an effort: I've done that for various spring configurations and versions in a distro - and I'm happy to contribute that - but it's quite big.

There are several tests verifying the presence or absence of the LoggingSpanExporter bean, for different configurations. See this test for example. You could do the same thing for the LoggingMetricExporter bean.

This PR is changing the spring factories, which are not used in the test you mentioned IIUC.

@jeanbisutti
Copy link
Member

My point was about the tests on the autoconfiguration creating the LoggingMetricExporter bean.

The test class for this autoconfiguration in fact already exists (LoggingMetricExporterAutoConfigurationTest).

@laurit laurit merged commit 2e5ac56 into open-telemetry:main Jan 30, 2024
47 checks passed
steverao pushed a commit to steverao/opentelemetry-java-instrumentation that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants