-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LoggingMetricExporterAutoConfiguration to spring factories #10282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be useful to add automatic tests as it's done for LoggingSpanExporter
adding external tests is quite an effort: I've done that for various spring configurations and versions in a distro - and I'm happy to contribute that - but it's quite big. |
There are several tests verifying the presence or absence of the |
It would be great to document this feature on https://opentelemetry.io/ after the next release |
This PR is changing the spring factories, which are not used in the test you mentioned IIUC. |
My point was about the tests on the autoconfiguration creating the The test class for this autoconfiguration in fact already exists ( |
it was forgotten before