Use direct peer address in client.address when X-Forwarded-For is not present
#10370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
approved these changes
Jan 31, 2024
|
@trask can you try to rerun failed tests? locally those tests were successful though. |
it looks like |
laurit
reviewed
Feb 5, 2024
| @@ -98,6 +98,7 @@ abstract class AbstractRatpackRoutesTest extends InstrumentationSpecification { | |||
| "$SemanticAttributes.NETWORK_PROTOCOL_VERSION" "1.1" | |||
| "$SemanticAttributes.SERVER_ADDRESS" { it == "localhost" || it == null } | |||
| "$SemanticAttributes.SERVER_PORT" { it == app.bindPort || it == null } | |||
| "$SemanticAttributes.CLIENT_ADDRESS" { it == "127.0.0.1" || it == null } | |||
There was a problem hiding this comment.
perhaps this should also be just "127.0.0.1"
There was a problem hiding this comment.
no, sometimes it will be null. similar to line 102.
laurit
approved these changes
Feb 5, 2024
|
thx @heyams! |
steverao
pushed a commit
to steverao/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 16, 2024
…ot present (open-telemetry#10370) Co-authored-by: heyams <heya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.