-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add host.id resource provider #10627
add host.id resource provider #10627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, had a couple small asks. I might have split this into two implementations -- one windows specific and one linux specific, and had the HostIdResourceProvider
delegate to them depending on the os type, but this is fine.
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
@laurit can you check? |
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
@breedx-splk could you review |
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
@breedx-splk you are blocking this PR from being merged, please review |
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
...library/src/main/java/io/opentelemetry/instrumentation/resources/HostIdResourceProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zeitlinger I left a PR against this PR to show you what I was talking about by removing the enum.
zeitlinger#1 👍🏻
…ve_enum Refactor to remove enum
@zeitlinger could you also update https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/resources/library/README.md Note that the existing doc is a bit inconsistent, it uses |
This page is also missing other resource providers. WDYT about adding a note to open-telemetry/opentelemetry.io#4027 to document resource providers on telemetry.io? |
The only one that is missing is |
OK, added 😄 |
this detector is meant for bare metal - if no cloud provider host detector was found