Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add host.id resource provider #10627

Merged
merged 14 commits into from
Mar 12, 2024

Conversation

zeitlinger
Copy link
Member

this detector is meant for bare metal - if no cloud provider host detector was found

@zeitlinger zeitlinger self-assigned this Feb 21, 2024
@zeitlinger zeitlinger requested a review from a team February 21, 2024 15:16
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had a couple small asks. I might have split this into two implementations -- one windows specific and one linux specific, and had the HostIdResourceProvider delegate to them depending on the os type, but this is fine.

@zeitlinger
Copy link
Member Author

@laurit can you check?

@laurit
Copy link
Contributor

laurit commented Feb 28, 2024

@laurit
Copy link
Contributor

laurit commented Mar 4, 2024

@breedx-splk could you review

@laurit laurit added this to the v2.2.0 milestone Mar 6, 2024
@laurit
Copy link
Contributor

laurit commented Mar 6, 2024

@breedx-splk you are blocking this PR from being merged, please review

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zeitlinger I left a PR against this PR to show you what I was talking about by removing the enum.
zeitlinger#1 👍🏻

@breedx-splk breedx-splk dismissed their stale review March 8, 2024 17:47

Seems fine mostly.

@laurit
Copy link
Contributor

laurit commented Mar 11, 2024

@zeitlinger could you also update https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/resources/library/README.md Note that the existing doc is a bit inconsistent, it uses Provider for some and Implementation for other. I think it should actually point to the provider class instead of the resource as provider should be the one that is used to disable it (isn't it?).

@zeitlinger
Copy link
Member Author

@zeitlinger could you also update https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/resources/library/README.md Note that the existing doc is a bit inconsistent, it uses Provider for some and Implementation for other. I think it should actually point to the provider class instead of the resource as provider should be the one that is used to disable it (isn't it?).

This page is also missing other resource providers. WDYT about adding a note to open-telemetry/opentelemetry.io#4027 to document resource providers on telemetry.io?

@laurit
Copy link
Contributor

laurit commented Mar 11, 2024

This page is also missing other resource providers. WDYT about adding a note to open-telemetry/opentelemetry.io#4027 to document resource providers on telemetry.io?

The only one that is missing is JarServiceNameDetector. Documenting on opentelemetry.io is going to be tricky , before that happens imo it would make sense to continue doing things as we have done so far.

@zeitlinger
Copy link
Member Author

This page is also missing other resource providers. WDYT about adding a note to open-telemetry/opentelemetry.io#4027 to document resource providers on telemetry.io?

The only one that is missing is JarServiceNameDetector. Documenting on opentelemetry.io is going to be tricky , before that happens imo it would make sense to continue doing things as we have done so far.

OK, added 😄

@github-actions github-actions bot requested a review from theletterf March 11, 2024 15:56
@trask trask merged commit 0029332 into open-telemetry:main Mar 12, 2024
49 checks passed
@zeitlinger zeitlinger deleted the host-id-resource-provider branch March 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants