-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure kafka metrics reporter as class #10855
Configure kafka metrics reporter as class #10855
Conversation
@SuppressWarnings("unchecked") | ||
private static Object mergeValue(Object o1, Object o2) { | ||
List<Object> result = new MetricsReporterList<>(); | ||
result.addAll((List<Object>) o1); | ||
result.add(o2); | ||
return result; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't follow why test needs to use the internal MetricsReporterList
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we have a test that tries to serialize the configuration
Line 132 in 17b6cad
void serializableConfig() throws IOException, ClassNotFoundException { |
ArrayList
here then the configuration will contain the list that includes OpenTelemetryMetricsReporter.class
which will fail in Line 159 in 17b6cad
throw new IllegalStateException( |
OpenTelemetryMetricsReporterTest
isn't ideal either.
Resolves #10823
Resolves #9883