Fix spring kafka interceptor wrappers not delegating some methods #10935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
...n/java/io/opentelemetry/instrumentation/spring/kafka/v2_7/InstrumentedRecordInterceptor.java
Outdated
Show resolved
Hide resolved
| @@ -10,7 +10,8 @@ dependencies { | |||
|
|
|||
| implementation(project(":instrumentation:kafka:kafka-clients:kafka-clients-common:library")) | |||
|
|
|||
| compileOnly("org.springframework.kafka:spring-kafka:2.7.0") | |||
| // compiling against 2.8.0 to use methods that are not present in 2.7 | |||
| compileOnly("org.springframework.kafka:spring-kafka:2.8.0") | |||
There was a problem hiding this comment.
If bumping to v2.8.0, does the folder and package naming need to be updated too? e.g.:
- spring-kafka-2.7/ -> spring-kafka-2.8/
- io/opentelemetry/javaagent/instrumentation/spring/kafka/v2_7 -> io/opentelemetry/javaagent/instrumentation/spring/kafka/v2_8
There was a problem hiding this comment.
That version number is based on the earliest supported version. Even if we compile agains 2.8 the instrumentation still works for 2.7 that we use to run tests.
phillipdriver
approved these changes
Mar 24, 2024
trask
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10934