Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add instrumentation for RestTemplateBuilder #11054

Merged
merged 12 commits into from
Apr 11, 2024
Merged

add instrumentation for RestTemplateBuilder #11054

merged 12 commits into from
Apr 11, 2024

Conversation

zeitlinger
Copy link
Member

No description provided.

@zeitlinger zeitlinger self-assigned this Apr 8, 2024
@zeitlinger zeitlinger requested a review from a team April 8, 2024 15:32
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Apr 8, 2024
@zeitlinger zeitlinger mentioned this pull request Apr 8, 2024
Closed
This was referenced Apr 9, 2024
Merged
Merged
jeanbisutti
jeanbisutti reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@jeanbisutti jeanbisutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shouldSendTelemetry test method verifies many things.

Would it be possible to test the RestTemplateBuilder instrumentation from another test method calling an HTTP endpoint different from /ping (the one called in the shouldSendTelemetry test method)?

@zeitlinger
Copy link
Member Author

The shouldSendTelemetry test method verifies many things.

Would it be possible to test the RestTemplateBuilder instrumentation from another test method calling an HTTP endpoint different from /ping (the one called in the shouldSendTelemetry test method)?

good idea 😄 - done

@zeitlinger zeitlinger force-pushed the rest-template-builder branch from 5424be6 to 58c3a21 Compare April 10, 2024 08:45
@zeitlinger zeitlinger force-pushed the rest-template-builder branch from ff5f77f to 5fb82c5 Compare April 11, 2024 11:14
@zeitlinger zeitlinger added this to the v2.3.0 milestone Apr 11, 2024
@zeitlinger zeitlinger force-pushed the rest-template-builder branch from afdeef1 to ed1587a Compare April 11, 2024 14:45
@trask trask merged commit 7de246b into open-telemetry:main Apr 11, 2024
49 checks passed
@zeitlinger zeitlinger deleted the rest-template-builder branch April 12, 2024 07:49
@zeitlinger zeitlinger mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit left review comments

@jeanbisutti jeanbisutti jeanbisutti approved these changes

Assignees

@zeitlinger zeitlinger

Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zeitlinger @laurit @jeanbisutti @trask