spring mvc tests to java #11114
Merged
spring mvc tests to java #11114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some CI failure problem in your PR, you can solve them by referring to relevant document. |
aschugunov
force-pushed
the
spring-mvc-3.1-tests-to-java
branch
from
20f596b
to
db20304
Compare
steverao
reviewed
Apr 14, 2024
...g/spring-webmvc/spring-webmvc-3.1/javaagent/src/test/java/test/boot/SpringBootBasedTest.java
Outdated
Show resolved
Hide resolved
...g/spring-webmvc/spring-webmvc-3.1/javaagent/src/test/java/test/boot/SpringBootBasedTest.java
Outdated
Show resolved
Hide resolved
...spring-webmvc/spring-webmvc-3.1/javaagent/src/test/java/test/filter/ServletFilterConfig.java
Outdated
Show resolved
Hide resolved
...g/spring-webmvc/spring-webmvc-3.1/javaagent/src/test/java/test/filter/ServletFilterTest.java
Outdated
Show resolved
Hide resolved
...g/spring-webmvc/spring-webmvc-3.1/javaagent/src/test/java/test/filter/ServletFilterTest.java
Outdated
Show resolved
Hide resolved
...tion/spring/spring-webmvc/spring-webmvc-6.0/javaagent/src/test/java/SpringBootBasedTest.java
Outdated
Show resolved
Hide resolved
...tion/spring/spring-webmvc/spring-webmvc-6.0/javaagent/src/test/java/SpringBootBasedTest.java
Outdated
Show resolved
Hide resolved
...tion/spring/spring-webmvc/spring-webmvc-6.0/javaagent/src/test/java/SpringBootBasedTest.java
Outdated
Show resolved
Hide resolved
| import org.springframework.security.core.userdetails.UserDetails; | ||
|
|
||
| public class SavingAuthenticationProvider extends AbstractUserDetailsAuthenticationProvider { | ||
| public List<TestUserDetails> latestAuthentications = new ArrayList<>(); |
There was a problem hiding this comment.
Suggested change
| public List<TestUserDetails> latestAuthentications = new ArrayList<>(); | |
| List<TestUserDetails> latestAuthentications = new ArrayList<>(); |
|
|
||
| @Controller | ||
| public class TestController { | ||
| @RequestMapping("/basicsecured/endpoint") |
There was a problem hiding this comment.
It had better to add a blank line with above here. Other same problems can modify together.
|
@steverao thank you a lot for review |
laurit
approved these changes
May 8, 2024
hannahchan
pushed a commit
to hannahchan/opentelemetry-java-instrumentation
that referenced
this pull request
May 12, 2024
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.