Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constant span name when using Spring AMQP AnonymousQueues #11141

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Use constant span name when using Spring AMQP AnonymousQueues #11141

merged 3 commits into from
Apr 22, 2024

Conversation

swar8080
Copy link
Contributor

@swar8080 swar8080 commented Apr 16, 2024 •
edited
Loading

Closes #11132

@swar8080 swar8080 requested a review from a team April 16, 2024 03:01
laurit
laurit approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is possible to change the prefix that spring uses for anonymous queue names this won't solve the issue completely, though handling that would be complicated. I think that doing this is better than nothing.

@swar8080
Copy link
Contributor Author

As it is possible to change the prefix that spring uses for anonymous queue names this won't solve the issue completely, though handling that would be complicated. I think that doing this is better than nothing.

the AnonymousQueue spring code hasn't changed in 8 years so hopefully that means it's unlikely to change

@laurit laurit merged commit 84d0511 into open-telemetry:main Apr 22, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverao steverao steverao approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use consistent span names with Spring AMQP AnonymousQueues
3 participants
@swar8080 @laurit @steverao