-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert play-mvc-2.6 groovy to java #12340
Convert play-mvc-2.6 groovy to java #12340
Conversation
i expect this PR to be green after the CI build run :) |
named("latestDepTest") { | ||
enabled = testLatestDeps | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't triggering latestDepTest module test when i have -PtestLatestDeps=true locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You sure about that? Seems to work fine for me. Perhaps nothing was run because you had already run the tests and got the results from build cache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me 'invalidate cache' and try it without this.
will close and reopen to trigger CI builds rerun. errors are not related to my change. |
…vc-2.6-groovy-to-java
lauri's fix for those ktor failing tests was just merged in a few hours ago here, you might need to rebase/pull those into your branch to get this green |
…vc-2.6-groovy-to-java
No description provided.