Align SpringConfigProperties with DefaultConfigProperties #12398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
jeanbisutti
force-pushed
the
align-spring-config-properties-with-default-config-properties
branch
from
5485755
to
73c31cd
Compare
|
great catch! |
zeitlinger
approved these changes
Oct 7, 2024
steverao
reviewed
Oct 7, 2024
| if (value == null && name.equals("otel.exporter.otlp.protocol")) { | ||
| String normalizedName = ConfigUtil.normalizePropertyKey(name); | ||
| String value = environment.getProperty(normalizedName, String.class); | ||
| if (value == null && normalizedName.equals("otel.exporter.otlp.protocol")) { |
There was a problem hiding this comment.
Suggested change
| if (value == null && normalizedName.equals("otel.exporter.otlp.protocol")) { | |
| if (value == null && "otel.exporter.otlp.protocol".equals(normalizedName) { |
Maybe this is better, it can avoid the influence from upstream API. The line 116 is same.
There was a problem hiding this comment.
From my understanding, normalizedName can't be null at this point.
I would prefer to limit the changes in this PR.
I personally agree with your suggestion.
Perhaps this change could be discussed in another PR. Feel free to create it.
|
@steverao @zeitlinger Could you please have another look? |
zeitlinger
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultConfigPropertiesallows the user to retrieve a property value from an environment variable.This modification allows the user to get a property value from an environment variable and from the implementation of an OTel SDK SPI declared as a bean.