-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muzzle mismatch logs should be warnings in tests #1754
Muzzle mismatch logs should be warnings in tests #1754
Conversation
If that actually works as intended, then 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't totally love altering the log level based on the debug
flag. If I see something logged at warn
when the debug
flag is on, I think I'd be confused not to see that also logged when the debug
flag is off, and info+
is (generally) being logged.
But I don't hate it either 😄, so good with it until (if) we think of something better.
`-Dio.opentelemetry.javaagent.slf4j.simpleLogger.defaultLogLevel=debug` | ||
`-Dotel.javaagent.debug=true` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
But it is our original desire: to have muzzle logs on |
Hmm, maybe it's just a matter of naming the debug flag more clearly: if we used something like |
I think ideally we would do something like #566 (comment)
also, our debug logging is very verbose, which makes things get lost easily, even info/warnings we could consider not using the debug flag during tests (by default), especially after #1643, when we can have separate log level for testing code (e.g. nice to log full spans that are received from exporter) just stuff to think about / come back to later i'm good with this PR as-is, it does address a real need 👍 |
Resolves #534
This change actually changes muzzle mismatch logs to warnings everywhere, not only in tests - but hides them behind the
otel.javaagent.debug
config.