Add AsyncSpanEndStrategy for Reactor 3.x instrumentation #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaloFour
force-pushed
the
withspan-async-reactor
branch
2 times, most recently
from
8df981b
to
cfa8236
Compare
HaloFour
force-pushed
the
withspan-async-reactor
branch
from
242fcb9
to
1529c1c
Compare
HaloFour
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
| import io.opentelemetry.instrumentation.reactor.TracingOperator; | ||
| import net.bytebuddy.asm.Advice; | ||
|
|
||
| public class ReactorHooksAdvice { | ||
| @Advice.OnMethodExit(suppress = Throwable.class) | ||
| public static void postStaticInitializer() { | ||
| TracingOperator.registerOnEachOperator(); | ||
| AsyncSpanEndStrategies.getInstance().registerStrategy(ReactorAsyncSpanEndStrategy.INSTANCE); |
There was a problem hiding this comment.
How about adding this to TracingOperator? In the RxJava2 instrumentation the async span strategy is also usable by the library instrumentation.
mateuszrzeszutek
approved these changes
Apr 13, 2021
HaloFour
force-pushed
the
withspan-async-reactor
branch
from
4537f9a
to
f9a37af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an implementation of
AsyncSpanEndStrategywhich supports Reactor publishers returned from methods annotated with the@WithSpanannotation.