Netty4.1: remove our handler when original handler is removed #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
.../opentelemetry/javaagent/instrumentation/netty/v4_1/NettyChannelPipelineInstrumentation.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
May 18, 2021
trask
reviewed
May 18, 2021
There was a problem hiding this comment.
can you add a test, similar to the one for removing future listeners? https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/netty/netty-4.1/javaagent/src/test/groovy/ChannelFutureTest.groovy
mateuszrzeszutek
approved these changes
May 19, 2021
instrumentation/netty/netty-4.1/javaagent/src/test/groovy/ChannelPipelineTest.groovy
Show resolved
Hide resolved
…nelPipelineTest.groovy Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
laurit
changed the title
laurit
changed the title
laurit
commented
May 19, 2021
| @@ -40,7 +39,7 @@ | |||
| @Override | |||
| public void transform(TypeTransformer transformer) { | |||
| transformer.applyAdviceToMethod( | |||
| isMethod().and(nameStartsWith("write")), | |||
| isMethod().and(named("write").or(named("writeAndFlush"))), | |||
There was a problem hiding this comment.
epoll & kqueue channel implementations have methods starting with write that shouldn't be instrumented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1373