Change all instrumentation names to io.opentelemetry.{libName}-{libVersion} #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
| @@ -54,6 +54,6 @@ protected String dbOperation(Void connection, String operation, String ignored) | |||
|
|
|||
| @Override | |||
| protected String getInstrumentationName() { | |||
| return "io.opentelemetry.javaagent.elasticsearch-rest-common"; | |||
| return "io.opentelemetry.elasticsearch-rest-common"; | |||
There was a problem hiding this comment.
We have a few of those "common" tracers -- I'm hoping that once we migrate to the Instrumenter API everywhere those common modules will just contain shared extractor code, and each instrumentation module will construct their instrumenter separately and give it a separate name that'll contain a proper version.
| private static final String INSTRUMENTATION_NAME = "io.opentelemetry.javaagent.jedis-1.4"; | ||
| private static final String INSTRUMENTATION_NAME = "io.opentelemetry.lettuce-4.0"; |
There was a problem hiding this comment.
I guess it was good to go over all those names just to catch copy-paste mistakes like this one 😄
laurit
approved these changes
Jun 25, 2021
iNikem
approved these changes
Jun 26, 2021
anuraaga
approved these changes
Jun 26, 2021
trask
approved these changes
Jun 28, 2021
| * instrumentation library so that during troubleshooting it's possible to pinpoint what tracer | ||
| * produced problematic telemetry. | ||
| * | ||
| * <p>In this project we use a convention to encode the version of the instrument*ed* library into |
There was a problem hiding this comment.
version -> base version (or similar)
There was a problem hiding this comment.
Used "minimum supported" - it's a bit longer but also clearer than "base" version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1436