Move slf4j logger initialization to bootstrap module #3733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Jul 30, 2021
|
this may make it more difficult for distros to provide their own logging configuration, which is something that I'm interested in, and I think @pavolloffay is interested in as well (#566) |
And use a slf4j logger in the `ExtensionClassLoader` class
mateuszrzeszutek
force-pushed
the
move-logging-init-to-bootstrap
branch
from
83edabc to
14e2223
Compare
Hmm, that might be true, depending on what's exposed in the custom logging feature. Could you open an issue and clarify what are the requirements for that? |
|
I'll close that PR for now - and possibly will reopen it once things are clearer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use a slf4j logger in the
ExtensionClassLoaderclass