Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Config get*Property() methods to get*() #3881

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

mateuszrzeszutek
Copy link
Member

... and rewrite the rest of the Spock test to JUnit.

See #3866 (comment)

}

/**
* Returns a list-valued configuration property or {@code defaultValue} if a property with name
* {@code name} has not been configured. The format of the original value must be comma-separated,
* e.g. {@code one,two,three}.
*/
public List<String> getListProperty(String name, List<String> defaultValue) {
public List<String> getList(String name, List<String> defaultValue) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used simpler getList/getMap names instead of getCommaSeparatedValues/getCommaSeparatedMap that SDK uses -- all other method names are consistent with the ConfigProperties interface.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice change we can make to the SDK too (since it's alpha)

}

/**
* Returns a list-valued configuration property or {@code defaultValue} if a property with name
* {@code name} has not been configured. The format of the original value must be comma-separated,
* e.g. {@code one,two,three}.
*/
public List<String> getListProperty(String name, List<String> defaultValue) {
public List<String> getList(String name, List<String> defaultValue) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice change we can make to the SDK too (since it's alpha)

*/
@Deprecated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to leave all those old methods and make them deprecated -- muzzle wouldn't let me remove them in this PR, I'll have to do that in the next one.

@trask trask merged commit 8200319 into open-telemetry:main Aug 20, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the rename-config-methods branch November 18, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants