Add request param to EndTimeExtractor #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
laurit
approved these changes
Aug 25, 2021
iNikem
approved these changes
Aug 25, 2021
trask
approved these changes
Aug 25, 2021
anuraaga
approved these changes
Aug 26, 2021
anuraaga
reviewed
Aug 26, 2021
| @@ -36,7 +36,8 @@ | |||
| Instrumenter.<MessageWithDestination, Void>newBuilder( | |||
| otel, INSTRUMENTATION_NAME, spanNameExtractor) | |||
| .addAttributesExtractor(attributesExtractor) | |||
| .setTimeExtractors(MessageWithDestination::getStartTime, response -> Instant.now()) | |||
| .setTimeExtractors( | |||
| MessageWithDestination::getStartTime, (request, response) -> Instant.now()) | |||
There was a problem hiding this comment.
Maybe not related to this PR, is this supposed to be using nanoTime?
There was a problem hiding this comment.
It probably should -- I think it was using just System.currentTimeMillis()before the Instrumenter refactoring. I'll change that to take nanos into account in the next PR.
mateuszrzeszutek
force-pushed
the
instrumenter-api-EndTimeExtractor
branch
from
3b0e0bb
to
bdadd5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there's no response and we use
Void, and sometimes the request type is stateful and keeps all the info - it's useful to have it in theEndTimeExtractortoo.