-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default javaagent artifact to have exporters #4106
Merged
trask
merged 26 commits into
open-telemetry:main
from
trask:change-default-javaagent-to-all
Oct 2, 2021
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
af7a83e
Change default javaagent to all, introduce slim
trask d99849d
Update release builds
trask 9c6f04f
Update examples build
trask 9b20ff0
Update benchmark-overhead
trask 6ea1a07
Update benchmark-e2e
trask 6ab2c68
Update docs where ok pre-release
trask 6e53ea0
Update misc
trask 2a4839c
Fix references to fullJavaagentJar
trask 64df703
Fix it
trask 9c43849
Delete doc for pre-1.0 releases
trask 5113576
Attach backwards compatible "all" artifact to releases
trask 42f4830
Comment
trask 1687020
Comment
trask ae7e2d1
guessing
trask 2b9de15
fix
trask cc35263
Merge remote-tracking branch 'upstream/main' into change-default-java…
trask 6cdfbce
Merge remote-tracking branch 'upstream/main' into change-default-java…
trask f01fbf6
Update version
trask e6e4e3d
Merge remote-tracking branch 'upstream/main' into change-default-java…
trask 7b4b731
Merge remote-tracking branch 'upstream/main' into change-default-java…
trask 73226a0
Add otlp/grpc exporter to slim artifact
trask f6c3a94
Merge remote-tracking branch 'upstream/main' into change-default-java…
trask 1fa5ef6
Merge remote-tracking branch 'upstream/main' into change-default-java…
trask 49e1aa8
Merge remote-tracking branch 'upstream/main' into change-default-java…
trask 3db6c45
Fix comment
trask 61ab8fd
Merge remote-tracking branch 'upstream/main' into change-default-java…
trask File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@breedx-splk any idea with this change if the classifier check should be changed to
""
ornull
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea here that we'll be publishing the full agent with exporters now without the
-all
classifier? If so, then I think we should just remove the classifier check entirely.It looks like you're also publishing
-all
for backwards compat? Assuming that's temporary, yeah, I think we'll want to remove this classifier check...but it might be nice to see what the xml looks like after the first publish to confirm.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
-all
artifact will be attached to the github release for now for backwards compatibility, but won't be published.there will be a new artifact
-slim
published after this thothis works for me 👍