Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize shared servlet code (intro to #4317) #4785

Merged

Conversation

mateuszrzeszutek
Copy link
Member

#4317 will introduce a bootstrap module that'll contain classes moved from instrumentation-api. Library modules should not depend on a bootstrap module, because that's a javaagent only concept -- in fact, the whole servlet instrumentation should not have any library modules because a servlet library instrumentation does not exist.
In this PR I moved some of those shared "library" classes around and removed the servlet library modules.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mateuszrzeszutek mateuszrzeszutek merged commit 0dc410a into open-telemetry:main Dec 6, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the reorganize-servlet-code branch December 6, 2021 12:50
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
…elemetry#4785)

* Reorganize shared servlet code (intro to open-telemetry#4317)

* Fix dropwizard tests

* fix compile error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants