Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cgroup v2 #7167

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Support cgroup v2 #7167

merged 4 commits into from
Nov 15, 2022

Conversation

breedx-splk
Copy link
Contributor

This resolves #6694.

We've been tracking the update to cgroup version support and want to get ahead of the widespread usage. The surface of the existing ContainerResource has not changed, but its internals have been factored out to two "extractor" utilities -- one that understands cgroup v1 and another for v2. v1 is attempted and, if successful, the result is used. If v1 fails, then the ContainerResource will fall back to v2.

As mentioned in #6694, the approach taken in this PR is borrowed from this SO post combined with local experimentation on docker desktop on a Mac, which already uses cgroup2 v2.

@breedx-splk breedx-splk requested a review from a team November 15, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auto-detection of container information to resource if cgroupv2 is used
3 participants