Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible cgroupv2 container id parsing (and podman support) #7361

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

breedx-splk
Copy link
Contributor

This is based on a conversation in opentelemetry-go #3508 and to be more consistent with the js cgroupv2 parser impl.

Unsurprisingly, podman does not include the word docker in the mountinfo file. As a result, the container id parsing would fail from inside a podman container. This fixes that up to be more compatible.

@breedx-splk breedx-splk requested a review from a team December 6, 2022 18:56
@trask trask merged commit 264edd9 into open-telemetry:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants