Add HttpServerResponseCustomizer support for Servlet and Jetty #8095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
HttpServerResponseCustomizersupport for Servlet 2.2/3.0/5.0 and Jetty 8/11 instrumentations. Enabled testing for it in JaxRs tests as well since those should now all be covered due to servlet instrumentations. Fixed Jetty 11 test source set directory name.Known limitation - response headers do not work on Jetty 8 for internal exception pages caused by throwing an exception that is handled outside of instrumentation scope, working around this would require an additional instrumentation and/or keeping an expired
Contextinstance referenced by the response object. This does not appear to be an issue on Jetty 11. Additionally, callingServletResponse#resetcan wipe headers as well, for which there is no workaround (yet?) in this PR.